Skip to content

#5374 make requirements clear #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

#5374 make requirements clear #5375

wants to merge 1 commit into from

Conversation

BelphegorPrime
Copy link

Fixes #5374

@BelphegorPrime BelphegorPrime requested a review from a team July 24, 2022 06:34
@code-asher
Copy link
Member

I wonder if we should say vCPU? I see that terminology in Google Cloud and AWS.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #5375 (849c2e8) into main (0e9ec02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5375   +/-   ##
=======================================
  Coverage   72.42%   72.42%           
=======================================
  Files          30       30           
  Lines        1672     1672           
  Branches      366      366           
=======================================
  Hits         1211     1211           
  Misses        398      398           
  Partials       63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9ec02...849c2e8. Read the comment docs.

code-asher
code-asher requested changes Jul 27, 2022
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just marking this PR as changes requested while we talk about the terminology.

@jsjoeio jsjoeio self-assigned this Aug 8, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 8, 2022

Agreed, vCPU makes more sense.

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 8, 2022

image

I don't have permission to push to your branch so I'm going to close and open a new PR

@jsjoeio jsjoeio closed this Aug 8, 2022
@jsjoeio jsjoeio mentioned this pull request Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher requested changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs]: Requirements clearification
3 participants
@BelphegorPrime @code-asher @jsjoeio